I have a iOS interview,and failed. I need someone to give me advice how to improve .
This company gave me a home work, one iOS project ,which only have one screen a list of time table ,which from a web service. It is very worse way and not maintainable. Let me modify it let it become maintainable,and to do some test.
I have spent a way to modify the project,and add some unit test,uitest,snapshot test,performance test,integration test. Code coverage is 98.7%
This company ‘s code reviewer still not satisfied my code,mentioned code quality not good ,lack of design pattern, don’t know any architecture
Separation of concerns
- There are some level of separation between VC and network layer
- VC is 304 lines long and deals with loading, decoding and displaying of the data
- CommonLib is used as a kitchen sink
- Some tests are hitting the network (VC)
- VC is in a very mutable state
Code Quality (cleanliness, re-use, consistency, etc.) - Lots of commented code, inconsistent styling, print statements left in code, random white spacing between functions.
Comments complex part of the code
🤷 Documents and explains the architecture - lots of documentation but didn’t talk about architecture at a high level
As I am a sole iOS developer,never worked with other iOS developer before,
Is there anyway to improve code quality and architecture area of iOS proejct